[Backport release-22.05] maintainers: add Scrumplex and minion3665, tomlplusplus: init at 3.2.0, prismlauncher: init at 5.0#196721
Merged
SuperSandro2000 merged 6 commits intoNixOS:release-22.05from Oct 20, 2022
Conversation
17 tasks
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net> Signed-off-by: Skyler Grey <skyler3665@gmail.com>
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
77538e1 to
f9b1cf5
Compare
Scrumplex
approved these changes
Oct 19, 2022
Member
Author
|
@ofborg eval |
Scrumplex
approved these changes
Oct 19, 2022
Member
|
Result of 1 package built:
|
Member
Author
|
Given that #196624 will need to be backported manually, I'd like to wait until it's merged before merging this so we can put it in the same PR |
- Previously PolyMC was the suggested replacement for MultiMC - As PolyMC is marked as insecure and prismlauncher is a replacement, this commit suggests using it instead
Member
Author
|
Result of 1 package blacklisted:
2 packages built:
|
Scrumplex
approved these changes
Oct 19, 2022
LunNova
approved these changes
Oct 20, 2022
Member
LunNova
left a comment
There was a problem hiding this comment.
Builds and runs, tested a few instances migrated from polymc and seems to be working fine.
- Previously PolyMC was the suggested alternative - This commit replaces that with prismlauncher, as PolyMC is no longer secure
Scrumplex
approved these changes
Oct 20, 2022
SuperSandro2000
approved these changes
Oct 20, 2022
| github = "Scrumplex"; | ||
| githubId = 11587657; | ||
| keys = [{ | ||
| longkeyid = "rsa2048/0xC10411294912A422"; |
Member
There was a problem hiding this comment.
FYI you should regenerate a GPG key with more bits some time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This is a manual backport of #196624, as well as all its dependencies
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes