Skip to content

[Backport release-22.05] maintainers: add Scrumplex and minion3665, tomlplusplus: init at 3.2.0, prismlauncher: init at 5.0#196721

Merged
SuperSandro2000 merged 6 commits intoNixOS:release-22.05from
Minion3665:backport-196624-dependencies-to-2205
Oct 20, 2022
Merged

[Backport release-22.05] maintainers: add Scrumplex and minion3665, tomlplusplus: init at 3.2.0, prismlauncher: init at 5.0#196721
SuperSandro2000 merged 6 commits intoNixOS:release-22.05from
Minion3665:backport-196624-dependencies-to-2205

Conversation

@Minion3665
Copy link
Member

@Minion3665 Minion3665 commented Oct 19, 2022

Description of changes

This is a manual backport of #196624, as well as all its dependencies

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@Minion3665 Minion3665 added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Oct 19, 2022
@Minion3665 Minion3665 changed the title [Backport release-22.05] maintainers: add Scrumplex and Minion3665, tomlplusplus: init at 3.2.0 [Backport release-22.05] maintainers: add Scrumplex and minion3665, tomlplusplus: init at 3.2.0 Oct 19, 2022
Scrumplex and others added 3 commits October 19, 2022 09:09
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
Signed-off-by: Skyler Grey <skyler3665@gmail.com>
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
@Minion3665 Minion3665 force-pushed the backport-196624-dependencies-to-2205 branch from 77538e1 to f9b1cf5 Compare October 19, 2022 08:10
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Oct 19, 2022
@ofborg ofborg bot requested a review from Scrumplex October 19, 2022 08:18
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 19, 2022
@Minion3665
Copy link
Member Author

@ofborg eval

@ofborg ofborg bot requested a review from Scrumplex October 19, 2022 14:44
@LunNova
Copy link
Member

LunNova commented Oct 19, 2022

Result of nixpkgs-review pr 196721 run on x86_64-linux 1

1 package built:
  • tomlplusplus

@Minion3665 Minion3665 added the 9.needs: package (new) This needs a new package to be added label Oct 19, 2022
@Minion3665
Copy link
Member Author

Given that #196624 will need to be backported manually, I'd like to wait until it's merged before merging this so we can put it in the same PR

- Previously PolyMC was the suggested replacement for MultiMC
- As PolyMC is marked as insecure and prismlauncher is a replacement,
  this commit suggests using it instead
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation labels Oct 19, 2022
@Minion3665 Minion3665 changed the title [Backport release-22.05] maintainers: add Scrumplex and minion3665, tomlplusplus: init at 3.2.0 [Backport release-22.05] maintainers: add Scrumplex and minion3665, tomlplusplus: init at 3.2.0, prismlauncher: init at 5.0 Oct 19, 2022
@Minion3665 Minion3665 removed the 9.needs: package (new) This needs a new package to be added label Oct 19, 2022
@ofborg ofborg bot requested a review from Scrumplex October 19, 2022 21:47
@ofborg ofborg bot removed the 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. label Oct 19, 2022
@Minion3665
Copy link
Member Author

Result of nixpkgs-review pr 196721 run on x86_64-linux 1

1 package blacklisted:
  • nixos-install-tools
2 packages built:
  • prismlauncher
  • tomlplusplus

Copy link
Member

@LunNova LunNova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs, tested a few instances migrated from polymc and seems to be working fine.

- Previously PolyMC was the suggested alternative
- This commit replaces that with prismlauncher, as PolyMC is no longer
  secure
@ofborg ofborg bot requested a review from Scrumplex October 20, 2022 08:11
github = "Scrumplex";
githubId = 11587657;
keys = [{
longkeyid = "rsa2048/0xC10411294912A422";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI you should regenerate a GPG key with more bits some time

@SuperSandro2000 SuperSandro2000 merged commit 861de04 into NixOS:release-22.05 Oct 20, 2022
@Minion3665 Minion3665 deleted the backport-196624-dependencies-to-2205 branch October 20, 2022 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants